178e151019
Conflicts: - `app/models/user_settings.rb`: Upstream added a constraint on a setting textually close to glitch-soc-only settings. Applied upstream's change. - `lib/sanitize_ext/sanitize_config.rb`: Upstream added support for the `translate` attribute on a few elements, where glitch-soc had a different set of allowed elements and attributes. Extended glitch-soc's allowed attributes with `translate` as upstream did. - `spec/validators/status_length_validator_spec.rb`: Upstream refactored to use RSpec's `instance_double` instead of `double`, but glitch-soc had changes to tests due to configurable max toot chars. Applied upstream's changes while keeping tests against configurable max toot chars.
89 lines
3.5 KiB
Ruby
89 lines
3.5 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
describe StatusLengthValidator do
|
|
describe '#validate' do
|
|
it 'does not add errors onto remote statuses' do
|
|
status = instance_double(Status, local?: false)
|
|
subject.validate(status)
|
|
expect(status).to_not receive(:errors)
|
|
end
|
|
|
|
it 'does not add errors onto local reblogs' do
|
|
status = instance_double(Status, local?: false, reblog?: true)
|
|
subject.validate(status)
|
|
expect(status).to_not receive(:errors)
|
|
end
|
|
|
|
it 'adds an error when content warning is over MAX_CHARS characters' do
|
|
chars = StatusLengthValidator::MAX_CHARS + 1
|
|
status = instance_double(Status, spoiler_text: 'a' * chars, text: '', errors: activemodel_errors, local?: true, reblog?: false)
|
|
subject.validate(status)
|
|
expect(status.errors).to have_received(:add)
|
|
end
|
|
|
|
it 'adds an error when text is over MAX_CHARS characters' do
|
|
chars = StatusLengthValidator::MAX_CHARS + 1
|
|
status = instance_double(Status, spoiler_text: '', text: 'a' * chars, errors: activemodel_errors, local?: true, reblog?: false)
|
|
subject.validate(status)
|
|
expect(status.errors).to have_received(:add)
|
|
end
|
|
|
|
it 'adds an error when text and content warning are over MAX_CHARS characters total' do
|
|
chars1 = 20
|
|
chars2 = StatusLengthValidator::MAX_CHARS + 1 - chars1
|
|
status = instance_double(Status, spoiler_text: 'a' * chars1, text: 'b' * chars2, errors: activemodel_errors, local?: true, reblog?: false)
|
|
subject.validate(status)
|
|
expect(status.errors).to have_received(:add)
|
|
end
|
|
|
|
it 'counts URLs as 23 characters flat' do
|
|
chars = StatusLengthValidator::MAX_CHARS - 1 - 23
|
|
text = ('a' * chars) + " http://#{'b' * 30}.com/example"
|
|
status = instance_double(Status, spoiler_text: '', text: text, errors: activemodel_errors, local?: true, reblog?: false)
|
|
|
|
subject.validate(status)
|
|
expect(status.errors).to_not have_received(:add)
|
|
end
|
|
|
|
it 'does not count non-autolinkable URLs as 23 characters flat' do
|
|
text = ('a' * 476) + "http://#{'b' * 30}.com/example"
|
|
status = instance_double(Status, spoiler_text: '', text: text, errors: activemodel_errors, local?: true, reblog?: false)
|
|
|
|
subject.validate(status)
|
|
expect(status.errors).to have_received(:add)
|
|
end
|
|
|
|
it 'does not count overly long URLs as 23 characters flat' do
|
|
text = "http://example.com/valid?#{'#foo?' * 1000}"
|
|
status = instance_double(Status, spoiler_text: '', text: text, errors: activemodel_errors, local?: true, reblog?: false)
|
|
subject.validate(status)
|
|
expect(status.errors).to have_received(:add)
|
|
end
|
|
|
|
it 'counts only the front part of remote usernames' do
|
|
username = '@alice'
|
|
chars = StatusLengthValidator::MAX_CHARS - 1 - username.length
|
|
text = ('a' * chars) + " #{username}@#{'b' * 30}.com"
|
|
status = instance_double(Status, spoiler_text: '', text: text, errors: activemodel_errors, local?: true, reblog?: false)
|
|
|
|
subject.validate(status)
|
|
expect(status.errors).to_not have_received(:add)
|
|
end
|
|
|
|
it 'does count both parts of remote usernames for overly long domains' do
|
|
text = "@alice@#{'b' * 500}.com"
|
|
status = instance_double(Status, spoiler_text: '', text: text, errors: activemodel_errors, local?: true, reblog?: false)
|
|
|
|
subject.validate(status)
|
|
expect(status.errors).to have_received(:add)
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def activemodel_errors
|
|
instance_double(ActiveModel::Errors, add: nil)
|
|
end
|
|
end
|