* Add more granular OAuth scopes * Add human-readable descriptions of the new scopes * Ensure new scopes look good on the app UI * Add tests * Group scopes in screen and color-code dangerous ones * Fix wrong extra scope
87 lines
2.2 KiB
Ruby
87 lines
2.2 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe Api::V1::FiltersController, type: :controller do
|
|
render_views
|
|
|
|
let(:user) { Fabricate(:user) }
|
|
let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: scopes) }
|
|
|
|
before do
|
|
allow(controller).to receive(:doorkeeper_token) { token }
|
|
end
|
|
|
|
describe 'GET #index' do
|
|
let(:scopes) { 'read:filters' }
|
|
let!(:filter) { Fabricate(:custom_filter, account: user.account) }
|
|
|
|
it 'returns http success' do
|
|
get :index
|
|
expect(response).to have_http_status(200)
|
|
end
|
|
end
|
|
|
|
describe 'POST #create' do
|
|
let(:scopes) { 'write:filters' }
|
|
|
|
before do
|
|
post :create, params: { phrase: 'magic', context: %w(home), irreversible: true }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(200)
|
|
end
|
|
|
|
it 'creates a filter' do
|
|
filter = user.account.custom_filters.first
|
|
expect(filter).to_not be_nil
|
|
expect(filter.phrase).to eq 'magic'
|
|
expect(filter.context).to eq %w(home)
|
|
expect(filter.irreversible?).to be true
|
|
expect(filter.expires_at).to be_nil
|
|
end
|
|
end
|
|
|
|
describe 'GET #show' do
|
|
let(:scopes) { 'read:filters' }
|
|
let(:filter) { Fabricate(:custom_filter, account: user.account) }
|
|
|
|
it 'returns http success' do
|
|
get :show, params: { id: filter.id }
|
|
expect(response).to have_http_status(200)
|
|
end
|
|
end
|
|
|
|
describe 'PUT #update' do
|
|
let(:scopes) { 'write:filters' }
|
|
let(:filter) { Fabricate(:custom_filter, account: user.account) }
|
|
|
|
before do
|
|
put :update, params: { id: filter.id, phrase: 'updated' }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(200)
|
|
end
|
|
|
|
it 'updates the filter' do
|
|
expect(filter.reload.phrase).to eq 'updated'
|
|
end
|
|
end
|
|
|
|
describe 'DELETE #destroy' do
|
|
let(:scopes) { 'write:filters' }
|
|
let(:filter) { Fabricate(:custom_filter, account: user.account) }
|
|
|
|
before do
|
|
delete :destroy, params: { id: filter.id }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(200)
|
|
end
|
|
|
|
it 'removes the filter' do
|
|
expect { filter.reload }.to raise_error ActiveRecord::RecordNotFound
|
|
end
|
|
end
|
|
end
|